fix: own comments trigger NEW
This commit is contained in:
33
tui_test.go
33
tui_test.go
@@ -1752,6 +1752,39 @@ func TestPollingMarksNewThreadCommentsUnread(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestPollingDoesNotMarkViewerReplyUnread(t *testing.T) {
|
||||
m := NewApp(nil, "o", "r", false, 50, 10*time.Second)
|
||||
m.screen = threadScreen
|
||||
initial := PRDetails{
|
||||
PullRequest: PullRequest{ID: "pr", Owner: "o", Repository: "r", Number: 1},
|
||||
ViewerLogin: "me",
|
||||
Threads: []ReviewThread{{
|
||||
ID: "thread", Comments: []ReviewComment{{ID: "original", Author: "reviewer"}},
|
||||
}},
|
||||
}
|
||||
updated, _ := m.Update(detailsLoadedMsg{owner: "o", repo: "r", number: 1, details: initial})
|
||||
m = updated.(App)
|
||||
|
||||
refreshed := initial
|
||||
refreshed.Threads = []ReviewThread{{
|
||||
ID: "thread", Comments: []ReviewComment{
|
||||
{ID: "original", Author: "reviewer"},
|
||||
{ID: "own-reply", Author: "ME", Body: "sent by me"},
|
||||
},
|
||||
}}
|
||||
updated, _ = m.Update(detailsLoadedMsg{owner: "o", repo: "r", number: 1, details: refreshed})
|
||||
m = updated.(App)
|
||||
|
||||
if m.unreadThreads["thread"] || m.unreadComments["own-reply"] || len(m.updatedThreads) != 0 {
|
||||
t.Fatalf("viewer reply was marked new: threads=%v comments=%v updated=%v",
|
||||
m.unreadThreads, m.unreadComments, m.updatedThreads)
|
||||
}
|
||||
state := m.readState.Data["pr"]
|
||||
if !state.Comments["own-reply"] {
|
||||
t.Fatal("viewer reply was not persisted as read")
|
||||
}
|
||||
}
|
||||
|
||||
func TestResolvingThreadMarksItRead(t *testing.T) {
|
||||
service := &recordingService{}
|
||||
m := NewApp(service, "o", "r", false, 50, time.Second)
|
||||
|
||||
Reference in New Issue
Block a user