From 0dd3843c26bc2e31cd7a51860aec4a307c3d0b19 Mon Sep 17 00:00:00 2001 From: Pablu23 Date: Mon, 21 Jul 2025 10:30:41 +0200 Subject: [PATCH] Validate config input before starting first acme --- acme/acme.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/acme/acme.go b/acme/acme.go index 693b5ef..3948f47 100644 --- a/acme/acme.go +++ b/acme/acme.go @@ -32,6 +32,13 @@ type Acme struct { func SetupAcme(config *domainrouter.Config) (*Acme, error) { acme := config.Server.Ssl.Acme + + d, err := time.ParseDuration(acme.RenewTime) + if err != nil { + return nil, err + } + + // Maybe this should be reconsidered, to create a new private Key / account per Acme request var privateKey *ecdsa.PrivateKey if _, err := os.Stat(acme.KeyFile); errors.Is(err, os.ErrNotExist) { privateKey, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader) @@ -109,11 +116,6 @@ func SetupAcme(config *domainrouter.Config) (*Acme, error) { return nil, err } - d, err := time.ParseDuration(acme.RenewTime) - if err != nil { - return nil, err - } - return &Acme{ user: &user, client: client, @@ -150,10 +152,8 @@ func (a *Acme) RenewAcme() error { func (a *Acme) RegisterTicker() { for { - select { - case <-a.renewTicker.C: - a.RenewAcme() - } + <-a.renewTicker.C + a.RenewAcme() } }