From baab34464dedb7aae7191b21b8a24ea63d89232d Mon Sep 17 00:00:00 2001 From: Yasuhiro Matsumoto Date: Wed, 29 Jul 2026 09:47:29 +0900 Subject: [PATCH] Use the table name from xCreate args in vtable example --- _example/vtable/vtable.go | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/_example/vtable/vtable.go b/_example/vtable/vtable.go index c65535b..0e60827 100644 --- a/_example/vtable/vtable.go +++ b/_example/vtable/vtable.go @@ -20,13 +20,19 @@ type githubModule struct { } func (m *githubModule) Create(c *sqlite3.SQLiteConn, args []string) (sqlite3.VTab, error) { + // args holds the raw xCreate arguments: args[0] is the module name, + // args[1] the database name, args[2] the virtual table name, and any + // user arguments follow. + if len(args) < 3 { + return nil, fmt.Errorf("githubModule: unexpected arguments: %v", args) + } err := c.DeclareVTab(fmt.Sprintf(` CREATE TABLE %s ( id INT, full_name TEXT, description TEXT, html_url TEXT - )`, args[0])) + )`, args[2])) if err != nil { return nil, err } @@ -49,6 +55,9 @@ func (v *ghRepoTable) Open() (sqlite3.VTabCursor, error) { return nil, err } defer resp.Body.Close() + if resp.StatusCode != http.StatusOK { + return nil, fmt.Errorf("fetching repositories: %s", resp.Status) + } body, err := ioutil.ReadAll(resp.Body) if err != nil {