Pablu/go-sqlite3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1440 from mattn/fix-limit-example-stmt-leak

Browse Source 
Close prepared statement and fail if limit is not enforced in limit example
This commit is contained in:
mattn
2026-07-29 07:02:34 +00:00
committed by GitHub
parent 210e260470 18f2ec37d3
commit c1a1466c3d
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
_example/limit/limit.go
View File

@@ -32,6 +32,7 @@ func bulkInsert(db *sql.DB, query string, args []any) (err error) {
if err != nil { if err != nil {
return return
} }
defer stmt.Close()
_, err = stmt.Exec(args...) _, err = stmt.Exec(args...)
if err != nil { if err != nil {
@@ -89,11 +90,13 @@ func main() {
query, args = createBulkInsertQuery(num, num) query, args = createBulkInsertQuery(num, num)
err = bulkInsert(db, query, args) err = bulkInsert(db, query, args)
if err != nil { if err == nil {
if err != nil { log.Fatal("expected failure since SQLITE_LIMIT_VARIABLE_NUMBER is too small, but insert succeeded")
}
if !strings.Contains(err.Error(), "too many SQL variables") {
log.Fatalf("expected too many SQL variables error, got: %v", err)
}
log.Printf("expect failed since SQLITE_LIMIT_VARIABLE_NUMBER is too small: %v", err) log.Printf("expect failed since SQLITE_LIMIT_VARIABLE_NUMBER is too small: %v", err)
}
}
bigLimitVariableNumber := 999999 bigLimitVariableNumber := 999999
sqlite3conn.SetLimit(sqlite3.SQLITE_LIMIT_VARIABLE_NUMBER, bigLimitVariableNumber) sqlite3conn.SetLimit(sqlite3.SQLITE_LIMIT_VARIABLE_NUMBER, bigLimitVariableNumber)
@@ -103,11 +106,9 @@ func main() {
query, args = createBulkInsertQuery(500, num+num) query, args = createBulkInsertQuery(500, num+num)
err = bulkInsert(db, query, args) err = bulkInsert(db, query, args)
if err != nil {
if err != nil { if err != nil {
log.Fatal(err) log.Fatal(err)
} }
}
log.Println("no error if SQLITE_LIMIT_VARIABLE_NUMBER > 999") log.Println("no error if SQLITE_LIMIT_VARIABLE_NUMBER > 999")
} }