Pablu/go-sqlite3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

the SQLiteResult refers to the connection after it should no longer be referring to the connection. The fix is to fetch the answers before Exec returns, just in case someone wants them.

Browse Source
This commit is contained in:
Russ Cox
2013-05-11 21:43:31 +09:00
committed by mattn
parent 0f6f374d27
commit d93259577c
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
sqlite3.go
View File

@@ -99,7 +99,8 @@ type SQLiteStmt struct {
// Result struct. // Result struct.
type SQLiteResult struct { type SQLiteResult struct {
s *SQLiteStmt id int64
changes int64
} }
// Rows struct. // Rows struct.
@@ -295,12 +296,12 @@ func (s *SQLiteStmt) Query(args []driver.Value) (driver.Rows, error) {
// Return last inserted ID. // Return last inserted ID.
func (r *SQLiteResult) LastInsertId() (int64, error) { func (r *SQLiteResult) LastInsertId() (int64, error) {
return int64(C._sqlite3_last_insert_rowid(r.s.c.db)), nil return r.id, nil
} }
// Return how many rows affected. // Return how many rows affected.
func (r *SQLiteResult) RowsAffected() (int64, error) { func (r *SQLiteResult) RowsAffected() (int64, error) {
return int64(C._sqlite3_changes(r.s.c.db)), nil return r.changes, nil
} }
// Execute the statement with arguments. Return result object. // Execute the statement with arguments. Return result object.
@@ -312,7 +313,12 @@ func (s *SQLiteStmt) Exec(args []driver.Value) (driver.Result, error) {
if rv != C.SQLITE_ROW && rv != C.SQLITE_OK && rv != C.SQLITE_DONE { if rv != C.SQLITE_ROW && rv != C.SQLITE_OK && rv != C.SQLITE_DONE {
return nil, errors.New(C.GoString(C.sqlite3_errmsg(s.c.db))) return nil, errors.New(C.GoString(C.sqlite3_errmsg(s.c.db)))
} }
return &SQLiteResult{s}, nil
res := &SQLiteResult{
int64(C._sqlite3_last_insert_rowid(s.c.db)),
int64(C._sqlite3_changes(s.c.db)),
}
return res, nil
} }
// Close the rows. // Close the rows.