Do not clobber SQLite's default cost estimates in BestIndex

This commit is contained in:
Yasuhiro Matsumoto
2026-07-29 08:57:25 +09:00
parent 0cfec60306
commit 1f0b756378

View File

@@ -482,8 +482,22 @@ func goVBestIndex(pVTab unsafe.Pointer, icp unsafe.Pointer) *C.char {
if res.AlreadyOrdered {
info.orderByConsumed = C.int(1)
}
info.estimatedCost = C.double(res.EstimatedCost)
info.estimatedRows = C.sqlite3_int64(res.EstimatedRows)
// SQLite pre-initializes estimatedCost and estimatedRows with sensible
// defaults; overwriting them with the Go zero value would make every
// candidate plan look free and break query planning, so only pass
// values the implementation actually set.
if res.EstimatedCost > 0 {
info.estimatedCost = C.double(res.EstimatedCost)
}
if res.EstimatedRows > 0 {
var rows int64
if res.EstimatedRows >= float64(math.MaxInt64) {
rows = math.MaxInt64
} else {
rows = int64(res.EstimatedRows)
}
info.estimatedRows = C.sqlite3_int64(rows)
}
return nil
}